Typescript in svelte in builder #15063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
added
feature-branch
samwho
approved these changes
Nov 26, 2024
Comment on lines
-5
to
-10
| export let value = null | ||
| export let disabled = false | ||
| export let readonly = false | ||
| export let error = null | ||
| export let appendTo = undefined | ||
| export let ignoreTimezones = false |
There was a problem hiding this comment.
Yes. And typescript complained about that 😄
There was a problem hiding this comment.
I've actually removed this file altogether in my branch. BBUI is consumed by frontend-core so I saw the same issues, and this file is actually entirely unused. You can leave it in though - I can deal with the small conflict.
There was a problem hiding this comment.
I had the feeling that it was not used at all. I just did not want to remove it just in case some old app was using it somehow 🪄
| @@ -18,8 +18,6 @@ | |||
| export let palette | |||
| export let c1, c2, c3, c4, c5 | |||
|
|
|||
| // Area specific props | |||
| export let area | |||
mike12345567
approved these changes
Nov 26, 2024
Adding svelte checks to validate ts on build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling typescript on svelte in the builder. This PR only sets the right configuration for enabling using typescript in svelte, making use of it in a file in the builder and one in bbui.
This PR will be followed by another enabling using typescript instead of js, and further refactors of more files.
Some of the complex types had been just mapped to
anyto keep this one simple. Better typing across the stack will follow.Launchcontrol
Enable ts in svelte in the builder
Feature branch env
Feature Branch Link