Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort table names alphabetically when selecting data source #15110

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

andz-bb
Copy link
Contributor

@andz-bb andz-bb commented Dec 3, 2024

Description

Currently, tables are not sorted alphabetically when selecting a data source for a data provider. I think for Budibase DB, they're just sorted alphabetically by table id.

thanks to @poirazis for suggesting this fix

image

Addresses

https://discord.com/channels/733030666647765003/1014909112565379163/1313456575608000563

Before

SCR-20241203-luxz

After

SCR-20241203-lxfv

Launchcontrol

sort table names alphabetically when selecting data source

@andz-bb andz-bb requested a review from aptkingston December 3, 2024 16:00
Copy link

qa-wolf bot commented Dec 3, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added the size/s label Dec 3, 2024
@poirazis
Copy link
Contributor

poirazis commented Dec 3, 2024

Well that was fast @andz-bb !

Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about localeCompare! Nice one 👌

@andz-bb andz-bb merged commit 3d88d2e into master Dec 4, 2024
19 checks passed
@andz-bb andz-bb deleted the sort-table-names branch December 4, 2024 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants