Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client error SVG #15161

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix client error SVG #15161

merged 2 commits into from
Dec 12, 2024

Conversation

aptkingston
Copy link
Member

Description

After moving from rollup to vite we need to import SVG files slightly differently. Currently the error image when you don't have access to an app is broken.

Before:
image

After:
image

Copy link

qa-wolf bot commented Dec 11, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@aptkingston aptkingston marked this pull request as ready for review December 11, 2024 11:06
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aptkingston aptkingston merged commit 0a7fde5 into master Dec 12, 2024
20 checks passed
@aptkingston aptkingston deleted the fix/client-error-svg-2 branch December 12, 2024 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants