Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder aliases #15205

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Update builder aliases #15205

wants to merge 15 commits into from

Conversation

aptkingston
Copy link
Member

Description

This PR updates all root level alieased imports in the builder packages. Previously we manually aliased all top level imports such as components, stores and constants but we've recently ran into an issue where typescript is not happy about a root level constants import.

This PR updates the aliases so that anything imported as @/foo is resolved from the top level src directory, and also keeps TS happy. This has the added benefit of being able to import anything from its top level path without needing to manually add another alias for it like we used to.

Examples of before and after:
import { Something } from "constants" > import { Something } from "@/constants"
import { Component } from "components/common/data" > import { Component } from "@/components/common/data"

Copy link

qa-wolf bot commented Dec 18, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants