Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS SDK to V3 #15215

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update AWS SDK to V3 #15215

wants to merge 3 commits into from

Conversation

mike12345567
Copy link
Collaborator

@mike12345567 mike12345567 commented Dec 18, 2024

Description

For a while now we have needed to migrate from AWS SDK V2 to V3 - this is quite a big change with a lot of changing APIs, but luckily our usage of the AWS SDK is quite small.

I initially followed the guide here: https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/migrating.html and the tool it provides to start the migration off, however a lot of it did need to be done by hand as we make heavy use of presigned URLs and this is something that has changed quite a lot in the newer version.

The biggest difference is the fact that pre-signed URL generation is now an async function, previously this was a sync call and a lot of our call stack depended upon that - which is where the majority of the updates were required. I don't believe this is impactful from a performance point of view as the function is still doing the same work, but it is async incase the command you are pre-signing requires async work, which none of ours require.

Ignore the very large file difference, the majority of this comes from the yarn.lock changes required as AWS SDK V3 is broken down into lots of smaller packages rather than one gigantic one.

@mike12345567 mike12345567 self-assigned this Dec 18, 2024
@mike12345567 mike12345567 requested a review from a team as a code owner December 18, 2024 17:59
@mike12345567 mike12345567 requested review from adrinr and removed request for a team December 18, 2024 17:59
Copy link

qa-wolf bot commented Dec 18, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/l labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firestorm Data/Infra/Revenue Team size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant