Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing remaining grid stores #15266

Merged
merged 18 commits into from
Dec 31, 2024
Merged

Typing remaining grid stores #15266

merged 18 commits into from
Dec 31, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Dec 30, 2024

Description

Typing remaining grid stores

Copy link

qa-wolf bot commented Dec 30, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Dec 30, 2024
@adrinr adrinr force-pushed the typing/stores-grid-conditions branch 4 times, most recently from 35d5df2 to d728b9f Compare December 31, 2024 11:14
@adrinr adrinr force-pushed the typing/remaining-grid-stores branch from 86d0fff to 405c018 Compare December 31, 2024 11:16
@adrinr adrinr requested a review from aptkingston December 31, 2024 11:17
@adrinr adrinr marked this pull request as ready for review December 31, 2024 11:17
@adrinr adrinr requested a review from a team as a code owner December 31, 2024 11:17
@adrinr adrinr requested review from samwho and removed request for a team December 31, 2024 11:17
Base automatically changed from typing/stores-grid-conditions to master December 31, 2024 11:37
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @adrinr 👌

@adrinr adrinr merged commit 0923a90 into master Dec 31, 2024
20 checks passed
@adrinr adrinr deleted the typing/remaining-grid-stores branch December 31, 2024 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants