Refactor automation builder. #15494
Merged
Refactor automation builder. #15494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
requested review from
adrinr and
PClmnt
and removed request for
a team
PClmnt
approved these changes
Feb 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most calls to
createAutomationBuilderfollowed the same pattern: they passed inconfig, set a name, maybe set anappIdthat always matchedconfig.getAppId(). I've simplified this pattern so that you only have to docreateAutomationBuilder(config). The name was never used for anything anyway, but I've made it so that you can set it if you want with a newname(n: string)method on the builder.I've also set
appAction({ fields: {} })to be the default trigger, as most uses ofcreateAutomationBuilderwere doing this manually.Lastly, I removed a lot of duplication in the
AutomationBuilder.tsfile by making the creation of the step and filter functions the result of another function call, shortening them to one line each and making sure they're consistent. This will also make it a bit easier to add new ones in future.