Move snippets to sidepanel #15595
Open
Move snippets to sidepanel #15595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
commented
Feb 20, 2025
| @@ -1,5 +0,0 @@ | |||
| export enum SidePanel { | |||
There was a problem hiding this comment.
This is only used in a file, not worth having it in types
adrinr
commented
Feb 21, 2025
| {/if} | ||
| </Layout> | ||
| </div> | ||
|
|
||
| {#if showSnippetDrawer} |
There was a problem hiding this comment.
This is done as it was the easier way to clean the state. Otherwise, when creating multiple snippets, the state would be persisted instead of starting from a clean slate everytime
adrinr
requested review from
aptkingston and
mike12345567
and removed request for
aptkingston
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving snippets section in bindings in order to match the UX of helpers and other bindings. We discussed keeping the existing section for crud, but this made it harder to understand and to reuse some logic. Happy to discuss improvements and different approaches.
Screenshots
Snippets will be moved to the bindings side panel
Snippets will not appear on the text section
Screen.Recording.2025-02-21.at.12.25.46.mov
Snippets can be added from the side panel
Screen.Recording.2025-02-21.at.12.27.19.mov
Snippets can be edited from the side panel
Screen.Recording.2025-02-21.at.12.27.44.mov
Snippets can be deleted from the side panel
Screen.Recording.2025-02-21.at.12.28.29.mov
Upgrade flow will still be in there for non-licenced users
Screen.Recording.2025-02-21.at.12.36.11.mov
Launchcontrol
Moving snippets section to the binding side panel
Feature branch env
Feature Branch Link