Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing table permissions issue #3091

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Fixing table permissions issue #3091

merged 1 commit into from
Oct 19, 2021

Conversation

mike12345567
Copy link
Collaborator

Description

Fixing issue with permissions, if some permissions have already been set for a role an error would be thrown which would break the UI and make it impossible to setup permissions for other tables.

This issue has been seen in #2934 and #3017.

…set for a role an error would be thrown which would break the UI and make it impossible to setup permissions for other tables.
@mike12345567 mike12345567 self-assigned this Oct 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3091 (3631a79) into develop (2d8a8e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3091   +/-   ##
========================================
  Coverage    73.17%   73.17%           
========================================
  Files          132      132           
  Lines         3858     3858           
  Branches       536      536           
========================================
  Hits          2823     2823           
  Misses         719      719           
  Partials       316      316           
Impacted Files Coverage Δ
packages/server/src/api/controllers/permission.js 89.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340d52d...3631a79. Read the comment docs.

@mike12345567 mike12345567 merged commit 2612725 into develop Oct 19, 2021
@mike12345567 mike12345567 deleted the fix/table-perms branch October 19, 2021 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants