Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for query preview validation #4447

Merged
merged 4 commits into from
Feb 12, 2022
Merged

Fix for query preview validation #4447

merged 4 commits into from
Feb 12, 2022

Conversation

mike12345567
Copy link
Collaborator

Description

This fixes the validation in the released version for query preview, e.g. SQL queries. There was some problems with the validation using the new method of API request.

This issue has been mentioned in #4440 and #4431.

Also fixed an issue with button group being close together, no gap attribute, allowed it to be added so not to risk causing issues elsewhere.

@codecov-commenter
Copy link

Codecov Report

Merging #4447 (3aac333) into master (a897030) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4447   +/-   ##
=======================================
  Coverage   67.91%   67.92%           
=======================================
  Files         144      144           
  Lines        4922     4923    +1     
  Branches      761      761           
=======================================
+ Hits         3343     3344    +1     
  Misses       1105     1105           
  Partials      474      474           
Impacted Files Coverage Δ
...ges/server/src/api/controllers/query/validation.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a167c...3aac333. Read the comment docs.

@mike12345567 mike12345567 merged commit 04118fb into master Feb 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2022
@mike12345567 mike12345567 deleted the merge/4414 branch February 12, 2022 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants