Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table column config #4475

Merged
merged 7 commits into from
Feb 14, 2022
Merged

Table column config #4475

merged 7 commits into from
Feb 14, 2022

Conversation

aptkingston
Copy link
Member

Description

This PR adds a new component for configuring table columns. This feature is available on both the table component and table block.

The new available features are:

  • Add and remove columns
  • Drag to reorder columns
  • Set custom labels for columns
  • Quickly reset to add all columns

Some clarification of functionality:

  • Initially all columns are added, as before
  • You cannot remove all columns, and the delete icon will be disabled when you are down to one column remaining
  • The component does correctly handle if no columns are selected though, for example if the datasource has no columns available

This change is fully backwards compatible. The previous setting value was a flat array of column names. The new component can handle this format, and will transform it in to the new structure the first time it is saved.

Screenshots

image

Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aptkingston aptkingston merged commit caa318d into develop Feb 14, 2022
@aptkingston aptkingston deleted the table-column-config branch February 14, 2022 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants