Fix vite warnings #4501
Merged
Fix vite warnings #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogunpurple
approved these changes
Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick PR to fix the spam of
[vite] Failed to load source map for /node_modules/.vite/...when running the builder in dev. This was just caused by not actually including sourcemaps in the vite config, so I've instructed vite to use sourcemaps when not running in production.This change would probably also have helped us diagnose the recent issue with safari faster, as it would probably have pointed us to the source of the JS error being thrown due to the look behind regex.
I also addressed the other couple of vite warnings which were printed in the console - namely removing some empty style blocks and fixing some A11y issues.
Before:
After (no logs at all from vite in the builder):
