Checklist API performance on default tenants and email invitations #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll when looking up apps in multi-tenant envs.
Codecov Report
@@ Coverage Diff @@
## master #4526 +/- ##
=======================================
Coverage 67.92% 67.92%
=======================================
Files 144 144
Lines 4923 4923
Branches 761 761
=======================================
Hits 3344 3344
Misses 1105 1105
Partials 474 474
Continue to review full report at Codecov.
|
…ints were used.
aptkingston
reviewed
Feb 16, 2022
mike12345567
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue with the checklist call taking upwards of two seconds to respond. This is a relatively simple call, it shouldn't have any heavy database calls.
This also fixes #4522 - there was some issues introduced by the frontend-core that needed fixed for this flow to work correctly.
Can see the call here:
It appeared to be tied to the default tenant, as there was an edge case which meant that the default tenant couldn't use the more efficient app tenant lookup, instead it has to lookup the full list of app IDs. I added an efficient flag to the
getAllAppsfunction so that we can state that we want it to be as fast as possible, perhaps sacrificing some accuracy in the default tenant. This is fine for the checklist call because it only needs a list of apps in the tenant. This should speed up the login process for the default tenant fairly significantly.