Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect custom tenantIds in run migrations endpoint #4607

Merged
merged 14 commits into from
Feb 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/budibase/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ sources:
- https://github.com/Budibase/budibase
- https://budibase.com
type: application
version: 0.2.7
version: 0.2.8
appVersion: 1.0.48
dependencies:
- name: couchdb
Expand Down
3 changes: 3 additions & 0 deletions charts/budibase/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ globals:
cookieDomain: ""
platformUrl: ""
httpMigrations: "0"
google:
clientId: ""
secret: ""

createSecrets: true # creates an internal API key, JWT secrets and redis password for you

Expand Down
7 changes: 5 additions & 2 deletions hosting/nginx.dev.conf.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ events {
http {
include /etc/nginx/mime.types;
default_type application/octet-stream;
proxy_set_header Host $host;

log_format main '$remote_addr - $remote_user [$time_local] "$request" '
'$status $body_bytes_sent "$http_referer" '
Expand Down Expand Up @@ -43,6 +44,10 @@ http {
proxy_pass http://{{ address }}:4001;
}

location = / {
proxy_pass http://{{ address }}:4001;
}

location /app_ {
proxy_pass http://{{ address }}:4001;
}
Expand All @@ -63,7 +68,6 @@ http {
proxy_http_version 1.1;
proxy_set_header Connection $connection_upgrade;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
}
Expand All @@ -72,7 +76,6 @@ http {
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header Host $http_host;

proxy_connect_timeout 300;
proxy_http_version 1.1;
Expand Down
4 changes: 1 addition & 3 deletions hosting/nginx.prod.conf.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ http {
limit_req_zone $binary_remote_addr zone=ratelimit:10m rate=20r/s;
include /etc/nginx/mime.types;
default_type application/octet-stream;
proxy_set_header Host $host;
charset utf-8;
sendfile on;
tcp_nopush on;
Expand Down Expand Up @@ -83,7 +84,6 @@ http {
proxy_http_version 1.1;
proxy_set_header Connection $connection_upgrade;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_pass http://$apps:4002;
Expand All @@ -110,7 +110,6 @@ http {
proxy_http_version 1.1;
proxy_set_header Connection $connection_upgrade;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;

Expand All @@ -126,7 +125,6 @@ http {
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header Host $http_host;

proxy_connect_timeout 300;
proxy_http_version 1.1;
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.0.68",
"version": "1.0.72",
"npmClient": "yarn",
"packages": [
"packages/*"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"build:docker:proxy:preprod": "lerna run generate:proxy:preprod && npm run build:docker:proxy",
"build:docker:proxy:prod": "lerna run generate:proxy:prod && npm run build:docker:proxy",
"build:docker:selfhost": "lerna run build:docker && cd hosting/scripts/linux/ && ./release-to-docker-hub.sh latest && cd -",
"build:docker:develop": "node scripts/pinVersions && lerna run build:docker && npm run build:docker:proxy && cd hosting/scripts/linux/ && ./release-to-docker-hub.sh develop && cd -",
"build:docker:develop": "node scripts/pinVersions && lerna run build:docker && npm run build:docker:proxy:compose && cd hosting/scripts/linux/ && ./release-to-docker-hub.sh develop && cd -",
"build:docker:airgap": "node hosting/scripts/airgapped/airgappedDockerBuild",
"build:digitalocean": "cd hosting/digitalocean && ./build.sh && cd -",
"build:docs": "lerna run build:docs",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend-core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@budibase/backend-core",
"version": "1.0.68",
"version": "1.0.72",
"description": "Budibase backend core libraries used in server and worker",
"main": "src/index.js",
"author": "Budibase",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend-core/src/cloud/accounts.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ exports.getAccount = async email => {
const json = await response.json()

if (response.status !== 200) {
throw Error(`Error getting account by email ${email}`, json)
throw new Error(`Error getting account by email ${email}`, json)
}

return json[0]
Expand Down
4 changes: 2 additions & 2 deletions packages/backend-core/src/context/deprovision.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const { getGlobalUserParams, getAllApps } = require("../db/utils")
const { getDB, getCouch } = require("../db")
const { getDB } = require("../db")
const { getGlobalDB } = require("../tenancy")
const { StaticDatabases } = require("../db/constants")

Expand Down Expand Up @@ -79,7 +79,7 @@ const removeGlobalDB = async tenantId => {

const removeTenantApps = async tenantId => {
try {
const apps = await getAllApps(getCouch(), { all: true })
const apps = await getAllApps({ all: true })
const destroyPromises = apps.map(app => getDB(app.appId).destroy())
await Promise.allSettled(destroyPromises)
} catch (err) {
Expand Down
2 changes: 1 addition & 1 deletion packages/backend-core/src/context/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ exports.getTenantId = () => {
}
const tenantId = cls.getFromContext(ContextKeys.TENANT_ID)
if (!tenantId) {
throw Error("Tenant id not found")
throw new Error("Tenant id not found")
}
return tenantId
}
Expand Down
3 changes: 3 additions & 0 deletions packages/backend-core/src/migrations/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ exports.getMigrationsDoc = async db => {
if (err.status && err.status === 404) {
return { _id: DocumentTypes.MIGRATIONS }
}
console.error(err)
}
}

Expand Down Expand Up @@ -94,6 +95,8 @@ exports.runMigrations = async (CouchDB, migrations, options = {}) => {
if (!options.tenantIds || !options.tenantIds.length) {
// run for all tenants
tenantIds = await getTenantIds()
} else {
tenantIds = options.tenantIds
}
} else {
// single tenancy
Expand Down
2 changes: 1 addition & 1 deletion packages/bbui/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@budibase/bbui",
"description": "A UI solution used in the different Budibase projects.",
"version": "1.0.68",
"version": "1.0.72",
"license": "MPL-2.0",
"svelte": "src/index.js",
"module": "dist/bbui.es.js",
Expand Down
10 changes: 5 additions & 5 deletions packages/builder/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@budibase/builder",
"version": "1.0.68",
"version": "1.0.72",
"license": "GPL-3.0",
"private": true,
"scripts": {
Expand Down Expand Up @@ -64,10 +64,10 @@
}
},
"dependencies": {
"@budibase/bbui": "^1.0.68",
"@budibase/client": "^1.0.68",
"@budibase/frontend-core": "^1.0.68",
"@budibase/string-templates": "^1.0.68",
"@budibase/bbui": "^1.0.72",
"@budibase/client": "^1.0.72",
"@budibase/frontend-core": "^1.0.72",
"@budibase/string-templates": "^1.0.72",
"@sentry/browser": "5.19.1",
"@spectrum-css/page": "^3.0.1",
"@spectrum-css/vars": "^3.0.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
<div class="helper__description">
{@html helper.description}
</div>
<pre class="helper__example">{helper.example || ''}</pre>
<pre class="helper__example">{helper.example || ""}</pre>
</div>
</li>
{/each}
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@budibase/cli",
"version": "1.0.68",
"version": "1.0.72",
"description": "Budibase CLI, for developers, self hosting and migrations.",
"main": "src/index.js",
"bin": {
Expand Down
8 changes: 4 additions & 4 deletions packages/client/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@budibase/client",
"version": "1.0.68",
"version": "1.0.72",
"license": "MPL-2.0",
"module": "dist/budibase-client.js",
"main": "dist/budibase-client.js",
Expand All @@ -19,9 +19,9 @@
"dev:builder": "rollup -cw"
},
"dependencies": {
"@budibase/bbui": "^1.0.68",
"@budibase/frontend-core": "^1.0.68",
"@budibase/string-templates": "^1.0.68",
"@budibase/bbui": "^1.0.72",
"@budibase/frontend-core": "^1.0.72",
"@budibase/string-templates": "^1.0.72",
"regexparam": "^1.3.0",
"rollup-plugin-polyfill-node": "^0.8.0",
"shortid": "^2.2.15",
Expand Down
4 changes: 2 additions & 2 deletions packages/frontend-core/package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"name": "@budibase/frontend-core",
"version": "1.0.68",
"version": "1.0.72",
"description": "Budibase frontend core libraries used in builder and client",
"author": "Budibase",
"license": "MPL-2.0",
"svelte": "src/index.js",
"dependencies": {
"@budibase/bbui": "^1.0.68",
"@budibase/bbui": "^1.0.72",
"lodash": "^4.17.21",
"svelte": "^3.46.2"
}
Expand Down
8 changes: 4 additions & 4 deletions packages/server/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@budibase/server",
"email": "hi@budibase.com",
"version": "1.0.68",
"version": "1.0.72",
"description": "Budibase Web Server",
"main": "src/index.ts",
"repository": {
Expand Down Expand Up @@ -73,9 +73,9 @@
"license": "GPL-3.0",
"dependencies": {
"@apidevtools/swagger-parser": "^10.0.3",
"@budibase/backend-core": "^1.0.68",
"@budibase/client": "^1.0.68",
"@budibase/string-templates": "^1.0.68",
"@budibase/backend-core": "^1.0.72",
"@budibase/client": "^1.0.72",
"@budibase/string-templates": "^1.0.72",
"@bull-board/api": "^3.7.0",
"@bull-board/koa": "^3.7.0",
"@elastic/elasticsearch": "7.10.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/server/scripts/dev/manage.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async function init() {
const envFileJson = {
PORT: 4001,
MINIO_URL: "http://localhost:4004",
COUCH_DB_URL: "http://budibase:budibase@localhost:10000/db/",
COUCH_DB_URL: "http://budibase:budibase@localhost:4005",
REDIS_URL: "localhost:6379",
WORKER_URL: "http://localhost:4002",
INTERNAL_API_KEY: "budibase",
Expand Down
2 changes: 1 addition & 1 deletion packages/server/src/db/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const allDbs = require("pouchdb-all-dbs")
const find = require("pouchdb-find")
const env = require("../environment")

const COUCH_DB_URL = getCouchUrl() || "http://localhost:10000/db/"
const COUCH_DB_URL = getCouchUrl() || "http://localhost:4005"

PouchDB.plugin(replicationStream.plugin)
PouchDB.plugin(find)
Expand Down
2 changes: 1 addition & 1 deletion packages/string-templates/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@budibase/string-templates",
"version": "1.0.68",
"version": "1.0.72",
"description": "Handlebars wrapper for Budibase templating.",
"main": "src/index.cjs",
"module": "dist/bundle.mjs",
Expand Down
6 changes: 3 additions & 3 deletions packages/worker/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@budibase/worker",
"email": "hi@budibase.com",
"version": "1.0.68",
"version": "1.0.72",
"description": "Budibase background service",
"main": "src/index.ts",
"repository": {
Expand Down Expand Up @@ -34,8 +34,8 @@
"author": "Budibase",
"license": "GPL-3.0",
"dependencies": {
"@budibase/backend-core": "^1.0.68",
"@budibase/string-templates": "^1.0.68",
"@budibase/backend-core": "^1.0.72",
"@budibase/string-templates": "^1.0.72",
"@koa/router": "^8.0.0",
"@sentry/node": "^6.0.0",
"@techpass/passport-openidconnect": "^0.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/worker/scripts/dev/manage.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ async function init() {
REDIS_URL: "localhost:6379",
REDIS_PASSWORD: "budibase",
MINIO_URL: "http://localhost:4004",
COUCH_DB_URL: "http://budibase:budibase@localhost:10000/db/",
COUCH_DB_URL: "http://budibase:budibase@localhost:4005",
COUCH_DB_USERNAME: "budibase",
COUCH_DB_PASSWORD: "budibase",
// empty string is false
Expand Down
2 changes: 1 addition & 1 deletion packages/worker/src/db/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const env = require("../environment")
const { getCouchUrl } = require("@budibase/backend-core/db")

// level option is purely for testing (development)
const COUCH_DB_URL = getCouchUrl() || "http://localhost:10000/db/"
const COUCH_DB_URL = getCouchUrl() || "http://localhost:4005"

let POUCH_DB_DEFAULTS = {
prefix: COUCH_DB_URL,
Expand Down