Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getting the current version #4621

Merged
merged 1 commit into from
Mar 6, 2022
Merged

fix getting the current version #4621

merged 1 commit into from
Mar 6, 2022

Conversation

mslourens
Copy link
Contributor

Description

Fixes the call to get the current version
Fixes #4545

Screenshots

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #4621 (028cdfc) into develop (aedc264) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4621      +/-   ##
===========================================
- Coverage    67.92%   67.91%   -0.01%     
===========================================
  Files          144      144              
  Lines         4923     4922       -1     
  Branches       761      761              
===========================================
- Hits          3344     3343       -1     
  Misses        1105     1105              
  Partials       474      474              
Impacted Files Coverage Δ
packages/server/src/api/controllers/row/utils.js 64.70% <50.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5862fc2...028cdfc. Read the comment docs.

@mslourens
Copy link
Contributor Author

The failing tests are not related to the changes I made. Should we rerun them, see if it helps?

@shogunpurple shogunpurple merged commit 65d55e1 into Budibase:develop Mar 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current version is not shown anymore
3 participants