Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress port conflicts / local dev fix #4649

Merged
merged 6 commits into from
Feb 25, 2022
Merged

Conversation

Rory-Powell
Copy link
Contributor

Description

  • Prevent port conflicts when running cypress locally alongside account portal
    • Account portal nginx runs on 10001
    • Change 10001 / 10002 in cypress to be 4100 / 4200 for server and worker respectively
    • 1000X gives the impression we are using a proxy, which cypress does not. Use the above to mimic 4001 / 4002
  • Update yarn commands to fix local dev

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #4649 (f37a4ee) into develop (b28d69e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4649   +/-   ##
========================================
  Coverage    67.91%   67.91%           
========================================
  Files          144      144           
  Lines         4922     4922           
  Branches       761      761           
========================================
  Hits          3343     3343           
  Misses        1105     1105           
  Partials       474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3249129...f37a4ee. Read the comment docs.

Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rory-Powell Rory-Powell merged commit bd30d2f into develop Feb 25, 2022
@Rory-Powell Rory-Powell deleted the fix/cypress-port-conflicts branch February 25, 2022 09:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants