-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve REST query naming in navigation #4700
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4700 +/- ##
========================================
Coverage 67.91% 67.91%
========================================
Files 144 144
Lines 4922 4922
Branches 761 761
========================================
Hits 3343 3343
Misses 1105 1105
Partials 474 474 Continue to review full report at Codecov.
|
@@ -109,6 +109,36 @@ export function customQueryIconColor(datasource, query) { | |||
} | |||
} | |||
|
|||
export function customQueryText(datasource, query) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the example usage of this in the pr description. Could we add unit tests for this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call actually, it's a perfect candidate. Will add some in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind actually - I forgot that we nuked jest from the builder since it was so horribly broken. This is just something we'll need to remember to add in once we've got a working jest setup again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! URLs look super clean - love the way it accounts for all different configurations.
Description
This PR updates the displayed names of REST queries in the navigation.
Described in #4175.
Behaviour
Example of REST datasource:
Examples of new naming