Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execute query action #4710

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Fix execute query action #4710

merged 2 commits into from
Feb 28, 2022

Conversation

aptkingston
Copy link
Member

Description

Quick fix for the execute query button action, which was working but then always throwing an error (for non-readable queries) due to incorrect syntax for showing a notification. This prevented automatic refreshing of data providers and prevented further button actions.

Also adding in an error notification since we should never have silent errors.

Fixes #4548

@aptkingston aptkingston changed the base branch from develop to master February 25, 2022 21:29
@aptkingston aptkingston merged commit 67f1560 into master Feb 28, 2022
@aptkingston aptkingston deleted the fix/execute-query-action branch February 28, 2022 08:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Refresh Data Provider" action not working after "Execute Query"
3 participants