Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various SQL fixes #4795

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Various SQL fixes #4795

merged 5 commits into from
Mar 7, 2022

Conversation

mike12345567
Copy link
Collaborator

Description

This PR introduces a few various fixes (mainly for SQL Server) to the SQL core system.

  1. Fix for no data returned from sql server 2016 tables #3839 - tested the non working table setup - some types weren't supported correctly.
  2. Fix for Doesn't recognize correct data types while fetching MS SQL tables #4652 - some SQL Server types weren't supported, such as bit, money and so on - updated these.
  3. Fix for SQL Server Load Data - Table schema other than dbo #4051 - schema setting is now allowed on SQL Server setup - also will only load tables from the correct schema now.

Screenshots

Showing the new Schema setting:
image

@mike12345567 mike12345567 self-assigned this Mar 4, 2022
shogunpurple
shogunpurple approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice fixes here.

@mike12345567 mike12345567 merged commit 4fedaed into develop Mar 7, 2022
@mike12345567 mike12345567 deleted the fix/sql-issues branch March 7, 2022 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shogunpurple shogunpurple shogunpurple approved these changes

Assignees

@mike12345567 mike12345567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike12345567 @shogunpurple