Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 upload component #4817

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Fix S3 upload component #4817

merged 2 commits into from
Mar 8, 2022

Conversation

aptkingston
Copy link
Member

Description

Somehow the S3 upload component stopped working due to being unable to resolve a sibling API call. I'm not sure what caused this to start failing all of a sudden, but in any case I've updated the API definitions to fix this.

I've also updated the error message so that it won't show [Object object] and fixed the loading state which previously would never be unset if errors happen.

Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aptkingston aptkingston merged commit 5928e93 into master Mar 8, 2022
@aptkingston aptkingston deleted the fix/s3-upload branch March 8, 2022 08:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants