-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick fixes for OpenAPI search response schema #4852
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4852 +/- ##
===========================================
+ Coverage 69.18% 69.19% +0.01%
===========================================
Files 145 145
Lines 5007 5012 +5
Branches 767 768 +1
===========================================
+ Hits 3464 3468 +4
- Misses 1089 1090 +1
Partials 454 454
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 2 out of 3 committers have signed the CLA. |
Description
As I've been working on the NextJS examples I noticed that there wasn't much of a definition available as a reference for the search schemas of the resources. This simply makes the search responses available as components that can be referenced, which importantly means that they can easily be used through our Typescript definitions that are generated from the OpenAPI spec - which makes the examples a bit more interesting.