Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes for OpenAPI search response schema #4852

Merged
merged 14 commits into from
Mar 9, 2022

Conversation

mike12345567
Copy link
Collaborator

@mike12345567 mike12345567 commented Mar 8, 2022

Description

As I've been working on the NextJS examples I noticed that there wasn't much of a definition available as a reference for the search schemas of the resources. This simply makes the search responses available as components that can be referenced, which importantly means that they can easily be used through our Typescript definitions that are generated from the OpenAPI spec - which makes the examples a bit more interesting.

@mike12345567 mike12345567 self-assigned this Mar 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #4852 (7707755) into develop (c3b6d74) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4852      +/-   ##
===========================================
+ Coverage    69.18%   69.19%   +0.01%     
===========================================
  Files          145      145              
  Lines         5007     5012       +5     
  Branches       767      768       +1     
===========================================
+ Hits          3464     3468       +4     
- Misses        1089     1090       +1     
  Partials       454      454              
Impacted Files Coverage Δ
...ackages/server/src/api/controllers/row/external.js 15.68% <0.00%> (ø)
packages/server/src/utilities/index.js 76.00% <80.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516cada...7707755. Read the comment docs.

Copy link
Contributor

@Rory-Powell Rory-Powell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

CLA Assistant Lite bot:

Thank you for your submission - we really appreciate it ❤️. Like many open-source projects, we ask that you all sign a Contributor License Agreement before we can accept your contribution.

You can sign the CLA by just posting a Pull Request Comment, the same as the text below.

If you are contributing on behalf of a company, your company should contact us to sign a Corporate Contributor License Agreement, via community@budibase.com.


I have read the CLA Document and I hereby sign the CLA


2 out of 3 committers have signed the CLA.
@shogunpurple
@mike12345567
@Budibase Staging Release Bot
Budibase Staging Release Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@mike12345567 mike12345567 merged commit a56bb19 into develop Mar 9, 2022
@mike12345567 mike12345567 deleted the fix/open-api-search branch March 9, 2022 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants