Skip to content

Conversation

@acotty
Copy link

@acotty acotty commented May 16, 2021

Updated most packages without breaking code or modifying tests.
Updated linting and test to use package.json scripts.
Added yarn lint and nodejs aray in github actions.
Bumped min NodeJS to 10.12.0 based on package dependency min nodejs versions found.

The following two package upgrades cause test failures and as such were NOT upgraded:

  1. engine-handlebars ^0.8.2 → ^1.1.0
    test\integration\templates.js:70 failures and more

  2. micromatch ^3.1.5 → ^4.0.4
    fs.js test failures

************************************** NYC COVERAGE REPORT BELOW **************************************

463 passing (2s)

-----------------|---------|----------|---------|---------|

File % Stmts % Branch % Funcs % Lines
All files 87.72 75 87.13 88.43
lib 87.16 74.56 86.24 87.92
array.js 87.78 73.74 96.77 90.07
code.js 100 100 100 100
collection.js 100 100 100 100
comparison.js 98.71 92.75 96 98.68
date.js 100 100 100 100
fs.js 100 100 100 100
html.js 100 93.33 100 100
i18n.js 100 100 100 100
index.js 100 100 100 100
logging.js 100 100 100 100
markdown.js 80 100 50 80
match.js 75 100 66.67 75
math.js 59.76 34.78 68.75 59.76
misc.js 63.64 40 75 63.64
number.js 92.42 78.57 100 93.75
object.js 100 96.43 100 100
path.js 72.09 50 87.5 72.09
regex.js 58.33 0 50 58.33
string.js 77.56 64.04 75 77.59
lib/utils 98.44 86.96 100 98.31
createFrame.js 93.75 50 100 93.33
html.js 100 100 100 100
index.js 100 100 100 100
----------------- --------- ---------- --------- ---------
=============================== Coverage summary ===============================
Statements : 87.72% ( 1136/1295 )
Branches : 75% ( 486/648 )
Functions : 87.13% ( 176/202 )
Lines : 88.43% ( 1070/1210 )
================================================================================

NOTE: I have removed the uncovered lines in the table above.

@shogunpurple
Copy link

LGTM when merge conflicts are fixed!

Copy link

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @acotty - thank you for the contribution!

@mike12345567 mike12345567 merged commit 414ad12 into Budibase:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants