Post Windows minidumps directly to S3

Runtime/Client/DotNetStandardClient.cs

@@ -1,7 +1,6 @@
 using BugSplatDotNetStandard;
 using System;
 using System.IO;
-using System.Linq;
 using System.Net.Http;
 using System.Threading.Tasks;
 
@@ -33,20 +32,9 @@ public Task<HttpResponseMessage> Post(FileInfo minidumpFileInfo, IReportPostOpti
 
         private ExceptionPostOptions CreateExceptionPostOptions(IReportPostOptions options)
         {
-            // TODO BG move IFormDataParam to BugSplatDotNetStandard
-            // https://github.com/BugSplat-Git/bugsplat-net-standard/issues/31
-            var formDataParams = options.AdditionalFormDataParams.Select(param =>
-            {
-                return new BugSplatDotNetStandard.FormDataParam()
-                {
-                    Content = param.Content,
-                    FileName = param.FileName,
-                    Name = param.Name
-                };
-            }).ToList();
             var exceptionPostOptions = new ExceptionPostOptions();
             exceptionPostOptions.AdditionalAttachments.AddRange(options.AdditionalAttachments);
-            exceptionPostOptions.AdditionalFormDataParams.AddRange(formDataParams);
+            exceptionPostOptions.AdditionalFormDataParams.AddRange(options.AdditionalFormDataParams);
             exceptionPostOptions.Description = options.Description;
             exceptionPostOptions.Email = options.Email;
             exceptionPostOptions.Key = options.Key;
@@ -57,20 +45,9 @@ private ExceptionPostOptions CreateExceptionPostOptions(IReportPostOptions optio
 
         private MinidumpPostOptions CreateMinidumpPostOptions(IReportPostOptions options)
         {
-            // TODO BG move IFormDataParam to BugSplatDotNetStandard
-            // https://github.com/BugSplat-Git/bugsplat-net-standard/issues/31
-            var formDataParams = options.AdditionalFormDataParams.Select(param =>
-            {
-                return new BugSplatDotNetStandard.FormDataParam()
-                {
-                    Content = param.Content,
-                    FileName = param.FileName,
-                    Name = param.Name
-                };
-            }).ToList();
             var minidumpPostOptions = new MinidumpPostOptions();
             minidumpPostOptions.AdditionalAttachments.AddRange(options.AdditionalAttachments);
-            minidumpPostOptions.AdditionalFormDataParams.AddRange(formDataParams);
+            minidumpPostOptions.AdditionalFormDataParams.AddRange(options.AdditionalFormDataParams);
             minidumpPostOptions.Description = options.Description;
             minidumpPostOptions.Email = options.Email;
             minidumpPostOptions.Key = options.Key;

Runtime/BugSplatDotNetStandard.deps.json → Runtime/Plugins/BugSplatDotNetStandard.deps.json

@@ -7,7 +7,7 @@
   "targets": {
     ".NETStandard,Version=v2.0": {},
     ".NETStandard,Version=v2.0/": {
-      "BugSplatDotNetStandard/2.0.6": {
+      "BugSplatDotNetStandard/2.1.2": {
         "dependencies": {
           "NETStandard.Library": "2.0.3"
         },
@@ -24,7 +24,7 @@
     }
   },
   "libraries": {
-    "BugSplatDotNetStandard/2.0.6": {
+    "BugSplatDotNetStandard/2.1.2": {
       "type": "project",
       "serviceable": false,
       "sha512": ""

Runtime/ReportPostOptions.cs

@@ -1,20 +1,14 @@
-using System.Collections.Generic;
+using BugSplatDotNetStandard;
+using System.Collections.Generic;
 using System.IO;
 using System.Net.Http;
 
 namespace BugSplatUnity
 {
-    public interface IFormDataParam
-    {
-        public string Name { get; set; }
-        public HttpContent Content { get; set; }
-        public string FileName { get; set; }
-    }
-
     public interface IReportPostOptions
     {
         public List<FileInfo> AdditionalAttachments { get; }
-        public List<IFormDataParam> AdditionalFormDataParams { get; }
+        public List<FormDataParam> AdditionalFormDataParams { get; }
         public string Description { get; set; }
         public string Email { get; set; }
         public string Key { get; set; }
@@ -32,7 +26,7 @@ public class FormDataParam : IFormDataParam
     public class ReportPostOptions : IReportPostOptions
     {
         public List<FileInfo> AdditionalAttachments { get; } = new List<FileInfo>();
-        public List<IFormDataParam> AdditionalFormDataParams { get; } = new List<IFormDataParam>();
+        public List<FormDataParam> AdditionalFormDataParams { get; } = new List<FormDataParam>();
         public string Description { get; set; }
         public string Email { get; set; }
         public string Key { get; set; }

Runtime/Util/ReportPostOptionsExtensions.cs

@@ -1,5 +1,4 @@
-using BugSplatUnity.Runtime.Client;
-using BugSplatUnity.Runtime.Settings;
+using BugSplatUnity.Runtime.Settings;
 
 namespace BugSplatUnity.Runtime.Util
 {

Tests/Runtime/Client/Fakes/FakeUnityWebClient.cs

@@ -58,7 +58,7 @@ public FakeDownloadHandler(string txt)
     class FakeExceptionPostOptions : IReportPostOptions
     {
         public List<FileInfo> AdditionalAttachments { get; }
-        public List<IFormDataParam> AdditionalFormDataParams { get; }
+        public List<FormDataParam> AdditionalFormDataParams { get; }
         public string Description { get; set; }
         public string Email { get; set; }
         public string Key { get; set; }