Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: codec MLLP #176

Merged
merged 5 commits into from
Nov 2, 2024
Merged

feat: codec MLLP #176

merged 5 commits into from
Nov 2, 2024

Conversation

Bugs5382
Copy link
Owner

@Bugs5382 Bugs5382 commented Nov 2, 2024

  • created a codec for MLLP data
  • faster than the old method and can make sure very long messages are parsed
  • removed any doubt of order of operations when getting a response back

#112 helps #169

[skip ci]

Search terms

Questioner

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Other things:

  • Write a unit test or update unit tests that cover your change in the code?
  • Set the PR to merge into the develop branch?
  • Clear documentation per the guidelines in the README.md as we are support medical applications?

- created a codec for MLLP data
- faster than the old method and can make sure very long messages are parsed
- removed any doubt of order of operations when getting a response back

[skip ci]
@Bugs5382 Bugs5382 added the enhancement New feature or request label Nov 2, 2024
@Bugs5382 Bugs5382 self-assigned this Nov 2, 2024
@Bugs5382 Bugs5382 mentioned this pull request Nov 2, 2024
- have to stop these units tests so we can get a new release out of this package. we will turn this on once everything is synced up.
- since node-hl7-server is  dev dependency it's ok to do this
- all the tests pass during local development version
@Bugs5382 Bugs5382 merged commit f84c8a4 into develop Nov 2, 2024
4 checks passed
@Bugs5382 Bugs5382 deleted the codec branch November 2, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant