-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow setting acknowledgment fields dynamically based on inbound message #114
Labels
Comments
@jtarvainen Looks good. Go ahead and submit one! |
Make sure you update the documentation with examples. |
Great! I'll get on it after the holidays. |
@jtarvainen Enjoy the holidays. :) |
@jtarvainen Updates? |
@Bugs5382 Thanks for the reminder, I'll get right on it. |
jtarvainen
pushed a commit
to jtarvainen/node-hl7-server-fork
that referenced
this issue
Jan 22, 2025
jtarvainen
pushed a commit
to jtarvainen/node-hl7-server-fork
that referenced
this issue
Jan 22, 2025
jtarvainen
pushed a commit
to jtarvainen/node-hl7-server-fork
that referenced
this issue
Jan 22, 2025
10 tasks
@jtarvainen I'll review this weekend during normal coding time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
Describe the Feature Request
Version 3.0.0 added support for overriding the acknowledgment message MSH content with the
mshOverrides
prop (#103). In updating to the new version, I realized that the functionality doesn't allow us to retrieve acknowledgment message field values from the inbound message because themshOverrides
content is specified upon server creation, before any messages are received.Describe Preferred Solution
I propose that we extend
mshOverrides
to accept, for each specified acknowledgment field, either field value as a string (as it does now) or a function that takes the inbound message as an optional argument and returns the field value.Related Code
We would define
mshOverrides
as follows:And use it like this:
And internally it would do this:
If the feature request is approved, would you be willing to submit a PR?
Yes!
The text was updated successfully, but these errors were encountered: