-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Non-breaking changes] Optimize receipt storing #368
Closed
trinhdn2
wants to merge
17
commits into
BuildOnViction:upgrade-core-develop
from
trinhdn2:optimize/receipt-storing
Closed
[Non-breaking changes] Optimize receipt storing #368
trinhdn2
wants to merge
17
commits into
BuildOnViction:upgrade-core-develop
from
trinhdn2:optimize/receipt-storing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinhdn2
changed the title
Optimize receipt storing
[Non-breaking changes] Optimize receipt storing
Jul 14, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attemps reduce the size of RLP encoded transaction receipts, also backwards compatibility is ensured.
These PRs must be merged first:
Instead of storing a full RLP encoded receipt including
we only need to store these crucial fields
the rest information can be derived from context and chain config
The backwards compatibility of the
DecodeRLP
method of a receipt is ensured. It will try to RLP decode based on the new receipt format first, if there is any error it will use the oldlegacyLegacyStoredReceipt
RLP format.