-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Non-breaking changes] Refactor trie interfaces #378
Closed
trinhdn2
wants to merge
45
commits into
BuildOnViction:master
from
trinhdn2:refactor/trie-interface-2
Closed
[Non-breaking changes] Refactor trie interfaces #378
trinhdn2
wants to merge
45
commits into
BuildOnViction:master
from
trinhdn2:refactor/trie-interface-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e' into refactor/trie-interface
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on separating some ambiguous methods of the
Trie
interface frominto clearer methods, indicating their usages
This PR also separates the preimage logic to a standalone struct called
preimageStore
. It should simplify the code a bit.Another big change in this PR: the preimage recording is disabled by default now.
These PRs must be merged first:
Refs: