Add packing for dynamic array and slice types #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinhdn2
commented
Sep 29, 2023
trinhdn2
commented
- This PR is derived from Add packing for dynamic array and slice types ethereum/go-ethereum#18051.
- It fixes the bug of encoding solidity function arguments for new pragma experimental ABIEncoderV2;. Related Issue is abi pack method doesn't encode new ABiEncoderV2 features like string[] correctly ethereum/go-ethereum#18033.
- Prepare for implement tuple packing/unpacking at issue Need tuple support for ABI library #383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.