-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: Implement websockets with github.com/gorilla/websocket #401
Closed
trinhdn2
wants to merge
129
commits into
BuildOnViction:upgrade-core-develop
from
trinhdn2:ft/use_gorilla_websocket
Closed
rpc: Implement websockets with github.com/gorilla/websocket #401
trinhdn2
wants to merge
129
commits into
BuildOnViction:upgrade-core-develop
from
trinhdn2:ft/use_gorilla_websocket
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th_call' into devnet
Optimize/estimate gas
Ft/parse abi once
trinhdn2
changed the title
Implement websockets with github.com/gorilla/websocket
rpc: Implement websockets with github.com/gorilla/websocket
Dec 5, 2023
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes package rpc use the
github.com/gorilla/websocket
packagefor WebSockets instead of
golang.org/x/net/websocket
. The new library is more robustand supports all WebSocket features including continuation frames.
There are new tests for two issues with the previously-used library:
DialWebsocket's handling of the default Origin header has changed. It used to set the
local machine's hostname as the origin, but that's weird and won't work with any
Internet-facing service. The new behavior is creating connections without an Origin
header unless one is provided explicitly.
This change also raises the request size limit for HTTP and WebSocket connections
to 5 MB. Quite a few people have reported issues where geth fails to deploy contracts
when they're too large, and retesteth needs a larger limit to upload the pre-state of large
tests.
References: