Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopify][Plugin]: Increasing limit for storefront shopify products api #3911

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[shopify][Plugin]: Increasing limit for storefront shopify products api #3911

wants to merge 3 commits into from

Conversation

anaghav2023
Copy link
Contributor

Description

This api is by default having a limit of 20 products, increasing it to a maximum of 250.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: dc5236d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@anaghav2023 anaghav2023 changed the title increasing limit for products api [shopifyPlugin]: Increasing limit for storefront shopify products api Feb 12, 2025
@anaghav2023 anaghav2023 changed the title [shopifyPlugin]: Increasing limit for storefront shopify products api [shopify][Plugin]: Increasing limit for storefront shopify products api Feb 12, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4142664.

Command Status Duration Result
nx test @e2e/sveltekit ❌ Failed 3m 22s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 7m 47s View ↗
nx test @e2e/qwik-city ✅ Succeeded 7m 25s View ↗
nx test @e2e/nuxt ✅ Succeeded 7m 6s View ↗
nx test @e2e/vue ✅ Succeeded 4m 23s View ↗
nx test @e2e/hydrogen ✅ Succeeded 5m 4s View ↗
nx test @e2e/react-sdk-next-15-app ✅ Succeeded 4m 50s View ↗
nx test @e2e/gen1-next15-app ✅ Succeeded 4m 49s View ↗
Additional runs (36) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-14 02:26:32 UTC

sanyamkamat
sanyamkamat reviewed Feb 12, 2025
View reviewed changes
plugins/shopify/src/plugin.ts
@@ -51,6 +51,7 @@ registerCommercePlugin(
(await client.product.fetchQuery({
query: search ? `title:*${search}*` : '',
sortKey: 'TITLE',
first: 250
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this for collection too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need in future. Added to collection as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanyamkamat sanyamkamat sanyamkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anaghav2023 @sanyamkamat