feat: angular sdk revamp with signals #4003
Conversation
🦋 Changeset detectedLatest commit: 750692d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 750692d.
☁️ Nx Cloud last updated this comment at |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9071768 | Triggered | Generic High Entropy Secret | d0f8228 | packages/sdks/e2e/angular-17/src/app/catch-all.component.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
sidmohanty11
changed the title
sidmohanty11
requested review from
a team,
samijaber and
sanyamkamat
and removed request for
a team
| { | ||
| "$schema": "./node_modules/ng-packagr/ng-package.schema.json", | ||
| "dest": "lib/browser", | ||
| "dest": "lib/edge", |
There was a problem hiding this comment.
can you explain this change?
There was a problem hiding this comment.
i think after Anagha's edge support got it in, when we run yarn g:nx build inside the angular output folder - it runs all of the builds in sequence and this gets updated one by one but technically this shouldn't affect anything
| }, | ||
| default: () => {}, | ||
| }); | ||
| }, [props.componentOptions, props.blockChildren]); |
| test.fail( | ||
| packageName === 'angular-16-ssr' || packageName === 'angular-16', | ||
| 'Angular Gen2 event binding not working properly for repeat blocks.' | ||
| ); |
| test.skip( | ||
| 
## Description Uses the Angular signals generator: BuilderIO/mitosis#1748 and does a major performance revamp fixes BuilderIO#3904 _Screenshot_ If relevant, add a screenshot or two of the changes you made.
3 participants
Description
Uses the Angular signals generator: BuilderIO/mitosis#1748 and does a major performance revamp
fixes #3904
Screenshot
If relevant, add a screenshot or two of the changes you made.