Skip to content

Commit

Permalink
fix: peer dependency range (#55)
Browse files Browse the repository at this point in the history
There's a subtle difference when alowwing peer. Better to go with a
range, otherwise the react, react-dom 16 will be picked

This fixes an issue when installing the package on some package managers



See the lock


![image](https://github.com/user-attachments/assets/54284f17-6fa7-4ae1-a7e5-14c17204afb2)

Co-authored-by: Sebastien Vanvelthem <sebastien.vanvelthem@weareretail.ai>
  • Loading branch information
belgattitude and Sebastien Vanvelthem authored Oct 3, 2024
1 parent fe782fd commit 05ea38d
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 76 deletions.
5 changes: 5 additions & 0 deletions .changeset/rare-pens-obey.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@builder.io/react-hydration-overlay": patch
---

Fix peer-dependency range
6 changes: 3 additions & 3 deletions packages/lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@
"lint-pkg": "pnpm pkg:publint && pnpm pkg:attw"
},
"peerDependencies": {
"react": ">=16",
"react-dom": ">=16",
"webpack": ">=4",
"react": "^16.14.0 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.14.0 || ^17.0.0 || ^18.0.0",
"webpack": "^4.0.0 || ^5.0.0",
"@spotlightjs/spotlight": "^1.2.11 || ^2.1.0"
},
"peerDependenciesMeta": {
Expand Down
86 changes: 13 additions & 73 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 05ea38d

Please sign in to comment.