Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to react-diff-viewer-continued for enhanced react 18+ support #48

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

belgattitude
Copy link
Contributor

@belgattitude belgattitude commented Oct 1, 2024

There's currently warnings when installing the library regarding react, react-dom.

As the react-diff-viewer package seems discontinued, I suggest to use an updated one: https://www.npmjs.com/package/react-diff-viewer-continued

This might also fix some issues

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 1c1000b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@builder.io/react-hydration-overlay Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samijaber
Copy link
Contributor

@belgattitude Thanks for all the PRs! I just added a CONTRIBUTING.md doc to highlight that we need changeset entries for each PR.

See https://github.com/BuilderIO/hydration-overlay/blob/main/CONTRIBUTING.md for more info, and please do this for all 3 of your PRs 🙏🏽

@belgattitude
Copy link
Contributor Author

belgattitude commented Oct 2, 2024

Done ! Let me know if the 'minor' changeset move is good... I can't really remember on pre-v1 what it does. My guess next version will be bumped to 0.2.0 (can be checked when the version release PR appears, we can fix there if not correct)

@samijaber samijaber merged commit 22b63c5 into BuilderIO:main Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants