Upgrade to BuildingSync Version 2.4 #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllong
force-pushed
the
feat/support-bsync-2.4
branch
from
46845e8 to
62563a9
Compare
nllong
commented
Nov 1, 2021
| bs_element.element_children.append( | ||
| (child_name, choice_element.element_full_name) | ||
| ) | ||
| if child_name and child_ref: |
There was a problem hiding this comment.
This was the chunk of code that was needed to resolve the reference not found issue. In short, we were not checking for references in choice elements.
nllong
commented
Nov 1, 2021
| [tool.poetry.dev-dependencies] | ||
| pytest = "^6.2.5" | ||
| pre-commit = "^2.15.0" | ||
| virtualenv = "20.09.0" |
There was a problem hiding this comment.
GitHub Actions does not support 20.10.0, yet...
nllong
commented
Nov 1, 2021
| dt = datetime.datetime(2019, 1, 1, 0, 0, 0) | ||
| ts = bsync.TimeSeriesData.TimeSeries.StartTimestamp(dt) | ||
| dt = datetime.datetime(2019, 1, 1, 8, 24, 59) | ||
| ts = bsync.StartTimestamp(dt) |
There was a problem hiding this comment.
several elements were promoted to complex/simple types, so they are now at the top level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11