Skip to content

Add GHG Emissions #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 31, 2022
Merged

Add GHG Emissions #16

merged 4 commits into from
Mar 31, 2022

Conversation

haneslinger
Copy link
Contributor

No description provided.

@haneslinger haneslinger mentioned this pull request Mar 25, 2022
Closed
haneslinger
haneslinger commented Mar 29, 2022
View reviewed changes
@haneslinger
Copy link
Contributor Author

the formatting passes locally 😖 idk why they aren't passing

JieXiong9119
JieXiong9119 approved these changes Mar 29, 2022
View reviewed changes
bsyncpy/bsync.py Outdated
element_enumerations = ["CO2e", "CO2", "CH4", "N2O", "NOx", "SO2", "Other"]
element_enumerations = [
"CO2e",
"MtCO2e",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to wait confirmation on schema side if we want to add this enumeration or not. MtCO2e is more like a unit than a type of emissions.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JieXiong9119 we are not adding this enumeration in the schema. Looks like it's been updated

@JieXiong9119
Copy link
Contributor

the formatting passes locally 😖 idk why they aren't passing

It looks like a poetry/pre-commit issue just appearing today. It's fixed on poetry side according to the issue here, but I don't know how to fix this on our side.

@laurenliz22
Copy link

the formatting passes locally 😖 idk why they aren't passing

It looks like a poetry/pre-commit issue just appearing today. It's fixed on poetry side according to the issue here, but I don't know how to fix this on our side.

I'm not sure how to fix this. @kflemin would you have any ideas?

@laurenliz22 laurenliz22 changed the title Add AnnualAverageGHGEmissions Add GHGE missions Mar 29, 2022
@laurenliz22 laurenliz22 changed the title Add GHGE missions Add GHG Emissions Mar 29, 2022
@haneslinger
Copy link
Contributor Author

Updating black like they did here fixed it

@JieXiong9119
Copy link
Contributor

Updating black like they did here fixed it

Nice! Looks like it's ready to go.

@kflemin
Copy link

kflemin commented Mar 30, 2022

Nice @haneslinger !!

@laurenliz22
Copy link

Updating black like they did here fixed it

Nice! Looks like it's ready to go.

Awesome, thanks @haneslinger!

@laurenliz22 laurenliz22 requested a review from nllong March 30, 2022 16:24
@nllong nllong merged commit 3e2b87a into develop Mar 31, 2022
@nllong nllong deleted the Add-GHG-Classes branch March 31, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nllong nllong nllong approved these changes

@laurenliz22 laurenliz22 laurenliz22 approved these changes

@JieXiong9119 JieXiong9119 JieXiong9119 approved these changes

@kflemin kflemin Awaiting requested review from kflemin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haneslinger @JieXiong9119 @laurenliz22 @kflemin @nllong