-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new parser system #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made: * feat: add mediawiki api struct with search working * feat: implement article_from_title for api handler * refactor: use map() for retrieving the article sections * feat: implement article_from_id for api handler * feat: implement search_at_offset for api handler * refactor: remove Search::origin and make result structs from api handler public * style: clean up the search offset fetching in search_from_json * refactor: create helper function for creating a query
Builditluc
added
state: approved
This issue or pull request was approved and can be worked on
type: refactor
Changes to the style and structure of the codebase or project
labels
Feb 6, 2023
Builditluc
removed
state: approved
This issue or pull request was approved and can be worked on
type: refactor
Changes to the style and structure of the codebase or project
labels
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made: