Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added macro to create enum with all languages at compile time #169

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

cshjsc
Copy link
Contributor

@cshjsc cshjsc commented Mar 20, 2023

I didn't do it through the build.rs, but this works too.

@cshjsc
Copy link
Contributor Author

cshjsc commented Mar 20, 2023

A problem I found with this is that because there are too many languages on the menu, as it is now you cannot scroll and can't search either, so you just have the languages that fit on the screen. I think there's a way to solve that easily but I'm no expert with the tui library

Copy link
Owner

@Builditluc Builditluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks great! Thank you! Will merge this when the changes are implemented

src/wiki/language.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@Builditluc
Copy link
Owner

as it is now you cannot scroll and can't search either

Yeah, I'm working on the search currently. Any view can be made scrollable by adding .scrollable() to it (see the commit I made in the main pr).

@Builditluc Builditluc added state: approved This issue or pull request was approved and can be worked on type: feature Implements a new feature labels Mar 21, 2023
@Builditluc Builditluc self-assigned this Mar 21, 2023
@cshjsc cshjsc force-pushed the language-switching branch from c47d388 to e5f4bb6 Compare March 21, 2023 17:27
Copy link
Owner

@Builditluc Builditluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Builditluc Builditluc merged commit 1a2fae8 into Builditluc:language-switching Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: approved This issue or pull request was approved and can be worked on type: feature Implements a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants