Block app popup for google amp links #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google loads its own copy of reddit results, which has its own 'read in reddit app' nuisances
more specific selectors to make rule more important
|
You can test on this url I got to that from searching google for "reddit stop asking app" and clicking on the first link. Google now loads reddit links on mobile searches through its special proxy-like service called AMP. This results in the page being loaded on a different domain and inside iframes, hence my changes in the manifest file. Also adds another css rule for the 'See Reddit in...' link that shows up in Google AMP reddit pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the 'See reddit in...' popup from google links.
Adds a new (very specific) css rule for another popup. And adds support for Google Amp links that show instead of reddit links when viewing results from a google search.