This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
PageContent loading state #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acostanzo
reviewed
Feb 9, 2023
| {children} | ||
| <Box | ||
| gridArea="content" | ||
| display={loading ? "grid" : "block"} |
There was a problem hiding this comment.
Should this be:
Suggested change
| display={loading ? "grid" : "block"} | |
| display={loading ? "flex" : "block"} |
There was a problem hiding this comment.
Both work, not sure if one is better than the other.
There was a problem hiding this comment.
Actually, turns out if I use display: flex then justify-self doesn't work on the box below.
Per MDN:
In flexbox layouts, this property is ignored. Read more about alignment in Flexbox.
dgalarza
force-pushed
the
dg-page-loading-state
branch
from
830d0ac to
46d0f73
Compare
dgalarza
force-pushed
the
dg-page-loading-state
branch
from
46d0f73 to
8d90947
Compare
dgalarza
force-pushed
the
dg-page-loading-state
branch
from
8d90947 to
daa8600
Compare
tute
approved these changes
Feb 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can eventually make this even nicer and utilize React's
<Suspense>but right now Apollo doesn't support it.apollographql/apollo-client#10231