add prometheus endpoint and metrics #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingerf
reviewed
Jan 25, 2017
| @@ -1 +1,3 @@ | |||
| slow_cooker* | |||
| Godeps/ | |||
| vendor/ | |||
There was a problem hiding this comment.
I've gone back and forth on this, but my preference is to check both of these directories into source control. Mind reverting the change in this file and adding Godeps/ and vendor/ to this PR?
esbie
approved these changes
Jan 25, 2017
This was referenced Jan 25, 2017
klingerf
reviewed
Jan 25, 2017
| @@ -198,6 +227,7 @@ func main() { | |||
| headers := make(headerSet) | |||
| flag.Var(&headers, "header", "HTTP request header. (can be repeated.)") | |||
| data := flag.String("data", "", "HTTP request data") | |||
| addr := flag.String("addr", ":8505", "service port to run on") | |||
There was a problem hiding this comment.
I'd vote to call this flag "metric-addr" or something more specific, since it only pertains the prometheus endpoint. I wouldn't want somebody confusing this with the addr of the host to which we're sending traffic. Also, I'd prefer for this flag to default to "", and for us not to start the metrics server at all, unless the addr is explicitly provided via the flag.
klingerf
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change introduces a
/metricsendpoint to the slow_cooker process.it currently exports 3 stats
note that unlike the existing histogram code, it only records latencies for successful requests. the intent is to not report low latencies to services that are failing fast. open to discussion on this.