Add a few TryFrom impls
#112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
approved these changes
Jul 11, 2022
BurntSushi
pushed a commit
that referenced
this pull request
Jul 11, 2022
The only reason these didn't exist is probably because I built bstr before (or too close to) when TryFrom was stabilized. But TryFrom has been available for quite some time, so it's good sense to add these impls now. Closes #112
BurntSushi
pushed a commit
that referenced
this pull request
Jul 11, 2022
The only reason these didn't exist is probably because I built bstr before (or too close to) when TryFrom was stabilized. But TryFrom has been available for quite some time, so it's good sense to add these impls now. Closes #112
BurntSushi
pushed a commit
that referenced
this pull request
Jul 11, 2022
The only reason these didn't exist is probably because I built bstr before (or too close to) when TryFrom was stabilized. But TryFrom has been available for quite some time, so it's good sense to add these impls now. Closes #112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to add support for using
bstrs in planus (see planus-org/planus#110).For the to work as outlined in the issue, I to make some of the generated code work the same for
str/BStrand forString/BString. The best way I have found to do this is to add theseTryFromimpls tobstr.