-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix @rev
parameter of dtolnay/rust-toolchain
#122
Conversation
Where did you get that from? Why is v1 wrong? |
https://github.com/dtolnay/rust-toolchain/blob/master/README.md
|
Bah. Well that's annoying. I'll take a closer look at this later. I have this same configuration repeated across a bunch of different repos. I'm sick and tired of having to update and tweak it, and doing it piecemeal is also annoying. So I'll probably figure out what I want to do and then do it everywhere. Thanks for bringing this to my attention. |
Although the repository does have a v1 tag. That's probably the reason this didn't blow up immediately. Maybe @dtolnay has plans to support the |
A I'll update For my own repos My guess is v1 will get bumped close to never, and if someone requests a bump they'd just get told to use master instead. |
dtolnay/rust-toolchain parses the desired toolchain version from the `@rev` parameter. If one wants to use the explicit `toolchain` input, `@master` should be specified.
It turns out that 'v1' exists but isn't really pully supported. Which makes sense. It's easier to just push stuff to master. So we switch to that too. Closes #122 Ref: #122 (comment)
The `v1` tag exists but isn't really supported. This mirrors [1]. See also [2]. [1]: BurntSushi/bstr@50086e7 [2]: BurntSushi/bstr#122 (comment)
dtolnay/rust-toolchain parses the desired toolchain version from the
@rev
parameter. If one wants to use the explicittoolchain
input,@master
should be specified.