Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @rev parameter of dtolnay/rust-toolchain #122

Closed
wants to merge 1 commit into from

Conversation

LingMan
Copy link
Contributor

@LingMan LingMan commented Aug 2, 2022

dtolnay/rust-toolchain parses the desired toolchain version from the @rev parameter. If one wants to use the explicit toolchain input, @master should be specified.

@BurntSushi
Copy link
Owner

@master should be specified

Where did you get that from? Why is v1 wrong?

@LingMan
Copy link
Contributor Author

LingMan commented Aug 2, 2022

https://github.com/dtolnay/rust-toolchain/blob/master/README.md

toolchain Rustup toolchain specifier e.g. stable, nightly, 1.42.0, nightly-2022-01-01. Important: the default is to match the @rev as described above. When passing an explicit toolchain as an input instead of @rev, you'll want to use "dtolnay/rust-toolchain@master" as the revision of the action.

@BurntSushi
Copy link
Owner

Bah. Well that's annoying.

I'll take a closer look at this later. I have this same configuration repeated across a bunch of different repos. I'm sick and tired of having to update and tweak it, and doing it piecemeal is also annoying. So I'll probably figure out what I want to do and then do it everywhere.

Thanks for bringing this to my attention.

@LingMan
Copy link
Contributor Author

LingMan commented Aug 2, 2022

Although the repository does have a v1 tag. That's probably the reason this didn't blow up immediately. Maybe @dtolnay has plans to support the @vN syntax after all?

@dtolnay
Copy link
Contributor

dtolnay commented Aug 2, 2022

A v﹏ tag is required in order to appear in search on https://github.com/marketplace?type=actions.

I'll update v1 occasionally to point to newer commits from master. I haven't done that in a while because I don't use the tag myself, so currently it doesn't include the most recent 2 PRs (one of which is a build speed improvement, so at least somewhat desirable).

For my own repos master is what I use, but I also don't care if other people refer to v1. They just won't be getting changes from PRs until later than master; TBD how much later. Also the functionality supported by v1 can be out of sync with the documentation which is rendered from master.

My guess is v1 will get bumped close to never, and if someone requests a bump they'd just get told to use master instead.

dtolnay/rust-toolchain parses the desired toolchain version from the `@rev` parameter. If one wants to use the explicit `toolchain` input, `@master` should be specified.
BurntSushi added a commit that referenced this pull request Sep 2, 2022
It turns out that 'v1' exists but isn't really pully supported. Which
makes sense. It's easier to just push stuff to master. So we switch to
that too.

Closes #122

Ref: #122 (comment)
@BurntSushi BurntSushi closed this in 50086e7 Sep 2, 2022
@LingMan LingMan deleted the patch-2 branch September 14, 2022 13:17
BurntSushi pushed a commit to BurntSushi/ripgrep that referenced this pull request Sep 29, 2022
The `v1` tag exists but isn't really supported.

This mirrors [1]. See also [2].

[1]: BurntSushi/bstr@50086e7
[2]: BurntSushi/bstr#122 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants