Add PartialEq and PartialOrd instances for byte arrays [u8; N]
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instances for `[u8; N]` and `&[u8; N]`, for convenience. Verified to work with current MSRV of 1.65. Add test for these impls.
joshtriplett
force-pushed
the
partial-eq-ord-array
branch
from
d127687 to
8b81735
Compare
lopopolo
reviewed
Oct 7, 2024
|
@lopopolo I think that would be a separate larger change, since bstr is built around |
|
The CI failure seems unrelated. #192 fixes it. |
BurntSushi
pushed a commit
that referenced
this pull request
Nov 13, 2024
Add instances for `[u8; N]` and `&[u8; N]`, for convenience. Closes #191
BurntSushi
pushed a commit
that referenced
this pull request
Nov 13, 2024
Add instances for `[u8; N]` and `&[u8; N]`, for convenience. Closes #191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instances for
[u8; N]and&[u8; N], for convenience.Verified to work with current MSRV of 1.65.
Add test for these impls.
Note that to test with the MSRV of 1.65, I had to manually downgrade
ucd-parsein the lockfile to 1.10, because newer versions have an MSRV of1.70. After downgrading that, the tests passed with 1.65.