Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ALIGN_MASK based on core::mem::align_of #197

Closed
wants to merge 2 commits into from
Closed

Introduce ALIGN_MASK based on core::mem::align_of #197

wants to merge 2 commits into from

Conversation

anforowicz
Copy link
Contributor

PTAL?

@anforowicz
Introduce ALIGN_MASK based on core::mem::align_of.
1af90f4 
Fixes BurntSushi#194
@anforowicz
Fix build failure on nightly rustc by explicitly specifying a lifetime.
a919e55 
Before this commit, the CI would fail [1] with:

```
error: elided lifetime has a name
  --> src/escape_bytes.rs:15:43
   |
14 | impl<'a> EscapeBytes<'a> {
   |      -- lifetime `'a` declared here
15 |     pub(crate) fn new(bytes: &'a [u8]) -> EscapeBytes {
   |                                           ^^^^^^^^^^^ this elided lifetime gets resolved as `'a`
   |
   = note: `-D elided-named-lifetimes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(elided_named_lifetimes)]`
```

[1] https://github.com/BurntSushi/bstr/actions/runs/11505596872/job/32027647754
@anforowicz anforowicz changed the title Itroduce ALIGN_MASK based on core::mem::align_of Introduce ALIGN_MASK based on core::mem::align_of Oct 25, 2024
BurntSushi pushed a commit that referenced this pull request Nov 13, 2024
@anforowicz @BurntSushi
safety: introduce ALIGN_MASK based on core::mem::align_of
d7a6e5c 
Fixes #194, Closes #197
@BurntSushi BurntSushi mentioned this pull request Nov 13, 2024
Merged
@anforowicz anforowicz deleted the align-bytes branch November 14, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anforowicz