Use a consistent return type for OsStr methods
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, hmmm, this LGTM. I'll merge this once I get to the 1.0 release. I'm not quite sure why I didn't do this originally. It looks like i went out of my way to avoid it. 🤔 |
|
Great. I was wondering if there was a reason for this I wasn't seeing. |
|
Fixing this is a breaking change, so I'm putting this in the 1.0 milestone. |
BurntSushi
pushed a commit
that referenced
this pull request
Jul 5, 2022
Previously, they would just return 'Vec<u8>' as the error type. But a 'FromUtf8Error' gives strictly more information, so we return that instead. Closes #52
BurntSushi
pushed a commit
that referenced
this pull request
Jul 5, 2022
Previously, they would just return 'Vec<u8>' as the error type. But a 'FromUtf8Error' gives strictly more information, so we return that instead. Closes #52
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be a good change to make before a 1.0 release.
It makes the return types consistent for
into_os_string,into_path_buf, andinto_string. They already match forByteSlice.