Fix typo in a doc comment of unsafe_read_slice.
#196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `$dst` has type `&mut [<numeric>]` rather than `&mut [u8]`.
BurntSushi
pushed a commit
that referenced
this pull request
Oct 5, 2023
Replace unsafe_read_slice macro which first copies data to destination buffer and then swaps endianess if necessary with a read_slice macro which does the swapping in a single pass while the data is read. This is done with `[T]:chunks_exact` which splits source into chunks which can be converted into integer of desired type with from_xx_bytes method. Closes #189, Closes #196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL?