-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe implementations of write_uint and write_uint128 #202
base: master
Are you sure you want to change the base?
Conversation
I think this probably LGTM, but the benchmarks should be compared before/after. Do you want to do that? |
Added some benchmarks in #206. I didn't compare super closely, but the performance seemed to be in the same range. |
Can you share the benchmark results when you get a chance? Thanks. |
Here's the results if the byte count isn't hard-coded (by using On the master branch:
With this PR:
|
And if the byte count is not black_box'd and gets inlined... On master:
With this PR:
|
No description provided.