Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crossbeam-channel link & update example #29

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Fix crossbeam-channel link & update example #29

merged 2 commits into from
Feb 20, 2019

Conversation

milkey-mouse
Copy link
Contributor

This is a very trivial change, but it saves a couple clicks for every visitor. crossbeam-channel is now part of the main crossbeam repository, so link to its (crossbeam-channel's) README instead of crossbeam's.

crossbeam-channel is now part of the main crossbeam repository, so link to its
README instead of that of the main repository. Saves two clicks ;)
@ghost
Copy link

ghost commented Feb 19, 2019

While we're at it, could you perhaps update the first example in the readme (the one with signals)? It was written in the v0.2 era when send() wasn't returning anything. Today, send() returns a Result.

So the suggestion is to change s.send(signal); to:

if s.send(signal).is_err() {
    break;
}

@BurntSushi
Copy link
Owner

Looks good with @stjepang's suggestion!

@milkey-mouse milkey-mouse changed the title Fix crossbeam-channel link Fix crossbeam-channel link & update example Feb 20, 2019
@milkey-mouse
Copy link
Contributor Author

I added that change in a separate commit.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit 65d2496 into BurntSushi:master Feb 20, 2019
@milkey-mouse milkey-mouse deleted the simplify-redirect branch February 20, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants