ci: Added uploading build artifacts and also build release #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a sample as well: https://github.com/mitchcapper/ripgrep/actions/runs/3258975771 |
|
I appreciate what you're trying to do here, but I do not want the headache of maintaining nightly release builds. IMO the build process for ripgrep is very easy and so I don't think it's a huge ask to build it yourself if you want to test/use whatever is on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload build artifacts for CI to allow people to easily grab nightly builds
Ran into the long file path issue, found the fix from last year: #2049 but as there were no nightly artifacts would need to clone and build just to test.
This also adds release building to the CI for tests (to get us both sets of artifacts).