Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore/types: add 'graphql' #2508

Closed
wants to merge 1 commit into from
Closed

Conversation

jparise
Copy link
Contributor

@jparise jparise commented May 6, 2023

GraphQL file extensions: .graphql and .graphqls (schema)

GraphQL file extensions: .graphql and .graphqls (schema)
@jparise
Copy link
Contributor Author

jparise commented May 6, 2023

Whoops, I hadn't noticed #2439 was already proposing a graphql type. I think the file extensions I chose (.graphql, .graphqls) are slightly more correct, however:

I excluded .gql, a commonly used abbreviated extension. It could conflict with other existing types (e.g. https://filext.com/file-extension/GQL), although I doubt many people are going to use -tgraphql in contexts where non-GraphQL .gql files appear.

@BurntSushi BurntSushi added the rollup A PR that has been merged with many others in a rollup. label Jul 5, 2023
@BurntSushi
Copy link
Owner

I'll go with this PR for now, since it's more conservative.

We can add .gql later if there's demand. It's inevitable that some extensions will conflict. That's OK.

BurntSushi pushed a commit that referenced this pull request Jul 8, 2023
GraphQL file extensions: .graphql and .graphqls (schema)

We could also add `.gql`, but perhaps it's less correct to do so. We'll
start conservatively here, and we can always add `.gql` later.

Closes #2439, Closes #2508
@BurntSushi BurntSushi closed this in 96cfc0e Jul 8, 2023
@jparise jparise deleted the types-graphql branch November 28, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR that has been merged with many others in a rollup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants